Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tiled edges to calculate frame inset sizes in Linux #39523

Merged
merged 1 commit into from Aug 17, 2023

Conversation

aiddya
Copy link
Contributor

@aiddya aiddya commented Aug 16, 2023

Description of Change

Adapt to the window frame size calculation changes in CL 3970920 by setting the inset sizes to 0 for tiled edges.

cc @jkleinsc

Fixes #39470

Checklist

Release Notes

Notes: Fixed decorations for tiled windows on Wayland.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2023
@jkleinsc jkleinsc added semver/patch backwards-compatible bug fixes target/22-x-y PR should also be added to the "22-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 16, 2023
Adapt to the window frame size calculation changes in CL 3970920 by
setting the inset sizes to 0 for tiled edges.
@github-actions github-actions bot added the target/27-x-y PR should also be added to the "27-x-y" branch. label Aug 16, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2023
@jkleinsc jkleinsc merged commit c75e193 into electron:main Aug 17, 2023
20 of 21 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 17, 2023

Release Notes Persisted

Fixed decorations for tiled windows on Wayland.

@trop
Copy link
Contributor

trop bot commented Aug 17, 2023

I have automatically backported this PR to "24-x-y", please check out #39567

@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Aug 17, 2023
@trop
Copy link
Contributor

trop bot commented Aug 17, 2023

I have automatically backported this PR to "22-x-y", please check out #39568

@trop
Copy link
Contributor

trop bot commented Aug 17, 2023

I have automatically backported this PR to "25-x-y", please check out #39569

@trop
Copy link
Contributor

trop bot commented Aug 17, 2023

I have automatically backported this PR to "27-x-y", please check out #39570

@trop trop bot removed the target/22-x-y PR should also be added to the "22-x-y" branch. label Aug 17, 2023
@trop
Copy link
Contributor

trop bot commented Aug 17, 2023

I have automatically backported this PR to "26-x-y", please check out #39571

@trop trop bot added in-flight/25-x-y in-flight/27-x-y in-flight/26-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 17, 2023
@aiddya aiddya deleted the tiled-edges-fix branch August 18, 2023 05:47
@trop trop bot added merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/25-x-y in-flight/26-x-y in-flight/27-x-y in-flight/22-x-y labels Aug 21, 2023
win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
…n#39523)

Adapt to the window frame size calculation changes in CL 3970920 by
setting the inset sizes to 0 for tiled edges.
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
…n#39523)

Adapt to the window frame size calculation changes in CL 3970920 by
setting the inset sizes to 0 for tiled edges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/22-x-y PR was merged to the "22-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: with wayland & gnome, maximizing a window to the side results in margin around the window
3 participants