fix: crash when calling BrowserWindow.moveTop() on modal children
#39499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-child-modal-parent
branch
from
6c12fba
to
c1f8532
Compare
codebytere
force-pushed
the
fix-child-modal-parent
branch
from
c1f8532
to
d076f6c
Compare
deepak1556
approved these changes
Aug 15, 2023
ckerr
approved these changes
Aug 15, 2023
zcbenz
approved these changes
Aug 16, 2023
|
Release Notes Persisted
|
This was referenced Aug 16, 2023
|
I have automatically backported this PR to "24-x-y", please check out #39526 |
trop
bot
added
in-flight/24-x-y
and removed
target/24-x-y
|
I have automatically backported this PR to "26-x-y", please check out #39527 |
|
I have automatically backported this PR to "25-x-y", please check out #39528 |
trop
bot
added
in-flight/26-x-y
in-flight/25-x-y
and removed
target/26-x-y
trop
bot
added
merged/25-x-y
win32ss
pushed a commit
to win32ss/supermium-electron
that referenced
this pull request
Sep 24, 2023
…lectron#39499) fix: crash when calling moveTop() on modal children
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…lectron#39499) fix: crash when calling moveTop() on modal children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #39413.
Follow-up to #39034.
We should only reorder child windows when the windows are not sheet windows.
Checklist
npm testpassesRelease Notes
Notes: Fixes a potential crash when calling
BrowserWindow.moveTop()on modal child windows.