Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate senderId and senderIsMainFrame #39381

Merged
merged 1 commit into from Aug 9, 2023
Merged

chore: deprecate senderId and senderIsMainFrame #39381

merged 1 commit into from Aug 9, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Aug 7, 2023

Follow-up to #39091

Notes: The senderId and senderIsMainFrame properties of IpcRendererEvent have been deprecated.

@miniak miniak requested a review from a team as a code owner August 7, 2023 00:09
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 7, 2023
@miniak miniak mentioned this pull request Aug 7, 2023
Merged
5 tasks
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport labels Aug 7, 2023
@miniak miniak self-assigned this Aug 7, 2023
dsanders11
dsanders11 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the follow-up!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 8, 2023
@jkleinsc jkleinsc merged commit 0f49868 into main Aug 9, 2023
14 checks passed
@jkleinsc jkleinsc deleted the miniak/deprecate-sender-id branch August 9, 2023 14:38
@release-clerk
Copy link

release-clerk bot commented Aug 9, 2023

Release Notes Persisted

The senderId and senderIsMainFrame properties of IpcRendererEvent have been deprecated.

win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@miniak
chore: deprecate senderId and senderIsMainFrame (electron#39381)
843b2b2
@commit-lint commit-lint bot mentioned this pull request Oct 18, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
chore: deprecate senderId and senderIsMainFrame (electron#39381)
1436c27
@nnguyen01
Copy link

Hey isn't senderIsMainFrame still useful in the case of main -> renderer communication?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees

@miniak miniak

Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miniak @nnguyen01 @ckerr @jkleinsc @codebytere @dsanders11