feat: support dns-result-order Node.js cli flag #39376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
added
target/25-x-y
erickzhao
reviewed
Aug 4, 2023
deepak1556
force-pushed
the
robo/support_dns_result_order
branch
from
926ee4c
to
7e0ffa6
Compare
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
|
The patch fails to apply. |
Co-authored-by: Erick Zhao <erick@hotmail.ca>
deepak1556
force-pushed
the
robo/support_dns_result_order
branch
from
7e0ffa6
to
4d0608f
Compare
|
|
|
Release Notes Persisted
|
This was referenced Aug 15, 2023
|
I have automatically backported this PR to "25-x-y", please check out #39500 |
trop
bot
added
in-flight/25-x-y
and removed
target/25-x-y
|
I have automatically backported this PR to "26-x-y", please check out #39501 |
trop
bot
added
merged/25-x-y
win32ss
pushed a commit
to win32ss/supermium-electron
that referenced
this pull request
Sep 24, 2023
* feat: support dns-result-order Node.js cli flag * chore: update docs Co-authored-by: Erick Zhao <erick@hotmail.ca> * chore: remove patch --------- Co-authored-by: Erick Zhao <erick@hotmail.ca>
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* feat: support dns-result-order Node.js cli flag * chore: update docs Co-authored-by: Erick Zhao <erick@hotmail.ca> * chore: remove patch --------- Co-authored-by: Erick Zhao <erick@hotmail.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This allows applications that load 3-party plugins to provide the legacy behavior with a process wide flag. There is also dns.setDefaultResultOder but it is per thread API so cannot be used effectively in a plugin process.
Checklist
npm testpassesRelease Notes
Notes: Add support for --dns-result-order Node.js cli flag