chore: document deprecated webContents.getPrinters API #39356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
added
semver/minor
electron-cation
bot
added
api-review/requested 🗳
new-pr 🌱
VerteDinde
approved these changes
Aug 3, 2023
codebytere
approved these changes
Aug 3, 2023
|
API LGTM |
1 task
|
Release Notes Persisted
|
|
I was unable to backport this PR to "26-x-y" cleanly; |
trop
bot
added
needs-manual-bp/26-x-y
and removed
target/26-x-y
dsanders11
added a commit
to dsanders11/electron
that referenced
this pull request
Aug 10, 2023
* chore: document deprecated webContents.getPrinters API * chore: remove duplicate deprecation warning
|
@dsanders11 has manually backported this PR to "26-x-y", please check out #39459 |
trop
bot
added
in-flight/26-x-y
merged/26-x-y
codebytere
pushed a commit
that referenced
this pull request
Aug 14, 2023
chore: document deprecated webContents.getPrinters API (#39356) * chore: document deprecated webContents.getPrinters API * chore: remove duplicate deprecation warning
5 tasks
win32ss
pushed a commit
to win32ss/supermium-electron
that referenced
this pull request
Sep 24, 2023
* chore: document deprecated webContents.getPrinters API * chore: remove duplicate deprecation warning
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* chore: document deprecated webContents.getPrinters API * chore: remove duplicate deprecation warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This API was marked in the docs as deprecated in #31023 (shipped in 17.0.0), but wasn't officially deprecated in
docs/breaking-changes.md. Let's do a proper deprecation and remove it next version.Checklist
Release Notes
Notes: The
webContents.getPrintersAPI has been deprecated.