Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for chrome.tabs.query #39330

Merged
merged 3 commits into from
Aug 9, 2023
Merged

feat: add support for chrome.tabs.query #39330

merged 3 commits into from
Aug 9, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 2, 2023 •
edited

Description of Change

Depends on #39317.

This PR adds support for chrome.tabs.query. This API is fairly commonly used by various framework devtools extensions, including the React DevTools extension.

Checklist

Release Notes

Notes: Added partial support for chrome.tabs.query.

@codebytere codebytere added semver/minor backwards-compatible functionality target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 2, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 2, 2023
@codebytere
Copy link
Member Author

Note: it's not a bug that zoilist didn't request review yet - it's because this PR is not yet targeting main.

@codebytere codebytere force-pushed the fix-tab-return-types branch 2 times, most recently from c3f8a86 to d878ac2 Compare August 3, 2023 08:39
Base automatically changed from fix-tab-return-types to main August 3, 2023 16:34
@codebytere codebytere mentioned this pull request Aug 3, 2023
Open
@codebytere codebytere added semver/minor backwards-compatible functionality and removed semver/minor backwards-compatible functionality labels Aug 3, 2023
erickzhao
erickzhao approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM :shipit:

@codebytere codebytere changed the title feat: add support for chrome.tabs.query and some events feat: add support for chrome.tabs.query Aug 4, 2023
samuelmaddock
samuelmaddock approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

shell/browser/extensions/api/tabs/tabs_api.cc Show resolved Hide resolved
@codebytere codebytere mentioned this pull request Aug 7, 2023
Closed
3 tasks
ckerr
ckerr approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit d932904 into main Aug 9, 2023
17 checks passed
@codebytere codebytere deleted the add-more-tabs-support branch August 9, 2023 12:47
@release-clerk
Copy link

release-clerk bot commented Aug 9, 2023

Release Notes Persisted

Added partial support for chrome.tabs.query.

This was referenced Aug 9, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 9, 2023

I have automatically backported this PR to "25-x-y", please check out #39430

@trop trop bot added in-flight/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels Aug 9, 2023
@trop
Copy link
Contributor

trop bot commented Aug 9, 2023

I have automatically backported this PR to "26-x-y", please check out #39431

@trop trop bot added in-flight/26-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/25-x-y in-flight/26-x-y labels Aug 9, 2023
win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@codebytere
feat: add support for chrome.tabs.query (electron#39330)
9f447d2 
* feat: add support for tabs.query

* fix: scope to webContents in current session

* test: add test for session behavior
@commit-lint commit-lint bot mentioned this pull request Oct 18, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
feat: add support for chrome.tabs.query (electron#39330)
1216e24 
* feat: add support for tabs.query

* fix: scope to webContents in current session

* test: add test for session behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@erickzhao erickzhao erickzhao approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
api-review/approved ✅ merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@codebytere @ckerr @samuelmaddock @VerteDinde @erickzhao