Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add senderIsMainFrame to messages sent via ipcRenderer.sendTo() #39207

Merged
merged 2 commits into from
Jul 27, 2023
Merged

feat: add senderIsMainFrame to messages sent via ipcRenderer.sendTo() #39207

merged 2 commits into from
Jul 27, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 24, 2023

Backport of #38868

See that PR for details.

Notes: Added senderIsMainFrame to messages sent via ipcRenderer.sendTo()

@trop trop bot requested a review from miniak July 24, 2023 12:28
@trop trop bot mentioned this pull request Jul 24, 2023
Merged
5 tasks
@trop trop bot added 24-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Jul 24, 2023
jkleinsc
jkleinsc requested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newly added test fails with:
electron/spec/api-ipc-renderer-spec.ts(169,32): error TS2304: Cannot find name 'once'. electron/spec/api-ipc-renderer-spec.ts(184,17): error TS2304: Cannot find name 'once'.

@trop @miniak @codebytere
feat: add senderIsMainFrame to messages sent via `ipcRenderer.sendT…
5714805 
…o()` (#38868)

* feat: add isMainFrame to events emitted via ipcRenderer.sendTo()

* chore: rename isMainFrame to senderIsMainFrame

Co-authored-by: Milan Burda <milan.burda@gmail.com>
@codebytere codebytere force-pushed the trop/24-x-y-bp-feat-add-senderismainframe-to-messages-sent-via-ipcrenderer-sendto--1690201674917 branch from a392a4f to 5714805 Compare July 26, 2023 08:15
@miniak miniak requested a review from jkleinsc July 26, 2023 08:57
@miniak
Copy link
Contributor

miniak commented Jul 26, 2023

@jkleinsc replaced with emittedOnce

codebytere
codebytere approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases on 07-27-2023

@codebytere codebytere merged commit e2d17db into 24-x-y Jul 27, 2023
13 checks passed
@codebytere codebytere deleted the trop/24-x-y-bp-feat-add-senderismainframe-to-messages-sent-via-ipcrenderer-sendto--1690201674917 branch July 27, 2023 20:59
@release-clerk
Copy link

release-clerk bot commented Jul 27, 2023

Release Notes Persisted

Added senderIsMainFrame to messages sent via ipcRenderer.sendTo()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
24-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @jkleinsc @codebytere