fix: instantiate tab video tracks from BrowserCaptureMediaStreamTrack

[brhenrique]

Description of Change

It seems display_surface in display_media_info wasn't correctly set when the display media source is a tab, which causes getDisplayMedia to return a MediaStreamTrack instead of BrowserCaptureMediaStreamTrack for browser sources.

Looking at the uses of DesktopMediaID::Parse in Chromium, it looks like the id it's supposed to receive is the id of a MediaStreamSource instead of the id of MediaStreamRequest.

With this change, it'll be possible to use the new Region Capture API with tab/browser capturing.

Fixes #36331

Before

After

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation, tutorials, templates and examples are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: support Region Capture API with tab MediaStream

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codebytere]

@brhenrique apologies for the delay - i've been a little busy but i haven't forgotten about this! i'll try to get to it next week :)

[zcbenz]

It seems that request.requested_video_device_id might be empty since it is just a request and the video_device.id is the actual chosen ID.

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

support Region Capture API with tab MediaStream

[trop]

I have automatically backported this PR to "25-x-y", please check out #39617

[trop]

I have automatically backported this PR to "26-x-y", please check out #39618

[trop]

I have automatically backported this PR to "27-x-y", please check out #39619

[BokFang]

@brhenrique
hello,I see you use getDisplayMedia to get a return BrowserCaptureMediaStreamTrack . But when I use your code in Electron renderer process, I got an Error which is "Uncaught (in promise) DOMException: Not supported".
How can I fix it?What is the correct way to use getDisplayMedia in Electron?
Thanks!

[brhenrique]

@BokFang https://www.electronjs.org/docs/latest/api/session#sessetdisplaymediarequesthandlerhandler

[BokFang]

@brhenrique
It works.Thanks!