Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make contentTracing.stopRecording() failure clearer #38520

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 31, 2023

Backport of #38488

See that PR for details.

Notes: Improve error message when contentTracing.stopRecording() fails because no trace was in progress.

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested a review from codebytere May 31, 2023 13:55
@trop trop bot added 24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 31, 2023
@jkleinsc jkleinsc merged commit 017fd30 into 24-x-y May 31, 2023
13 checks passed
@jkleinsc jkleinsc deleted the trop/24-x-y-bp-chore-make-contenttracing-stoprecording-failure-clearer-1685541302139 branch May 31, 2023 15:28
@release-clerk
Copy link

release-clerk bot commented May 31, 2023

Release Notes Persisted

Improve error message when contentTracing.stopRecording() fails because no trace was in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants