New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add USB protected classes handler #38493
Merged
jkleinsc
merged 5 commits into
25-x-y
from
trop/25-x-y-bp-feat-add-usb-protected-classes-handler-1685464540692
Jun 1, 2023
Merged
feat: add USB protected classes handler #38493
jkleinsc
merged 5 commits into
25-x-y
from
trop/25-x-y-bp-feat-add-usb-protected-classes-handler-1685464540692
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
4 tasks
trop
bot
added
25-x-y
backport
This is a backport PR
backport/requested 🗳
semver/minor
backwards-compatible functionality
labels
May 30, 2023
jkleinsc
approved these changes
May 30, 2023
georgexu99
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved on behalf of #releases-wg
jkleinsc
deleted the
trop/25-x-y-bp-feat-add-usb-protected-classes-handler-1685464540692
branch
June 1, 2023 14:15
Release Notes Persisted
|
erickzhao
pushed a commit
to erickzhao/ericktron
that referenced
this pull request
Jun 8, 2023
* feat: add USB protected classes handler Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * chore: apply review suggestions Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * chore: update docs Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * chore: apply review suggestions Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * update doc per suggestion Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
25-x-y
backport/approved ✅
backport
This is a backport PR
semver/minor
backwards-compatible functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #38263
See that PR for details.
Notes: Added setUSBProtectedClassesHandler to allow access to protected USB classes with WebUSB.