Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: win.isMaximized() for transparent windows on Windows #38343

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 17, 2023

Backport of #38234

See that PR for details.

Notes: Fixed an issue where calling win.minimize() directly after calling win.maximize(), and then calling win.isMaximized() incorrectly returns true.

@trop trop bot requested a review from codebytere May 17, 2023 08:17
@trop trop bot added 24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 17, 2023
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere force-pushed the trop/24-x-y-bp-fix-win-ismaximized-for-transparent-windows-on-windows-1684311446903 branch from c973aef to ce3a040 Compare May 17, 2023 08:26
@patchup patchup bot requested a review from a team as a code owner May 17, 2023 08:38
@codebytere codebytere merged commit d8e7457 into 24-x-y May 17, 2023
13 checks passed
@codebytere codebytere deleted the trop/24-x-y-bp-fix-win-ismaximized-for-transparent-windows-on-windows-1684311446903 branch May 17, 2023 11:09
@release-clerk
Copy link

release-clerk bot commented May 17, 2023

Release Notes Persisted

Fixed an issue where calling win.minimize() directly after calling win.maximize(), and then calling win.isMaximized() incorrectly returns true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant