fix: enable BrowserWindow.id access post-destruction
#38310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
4 tasks
trop
bot
added
24-x-y
backport
codebytere
approved these changes
May 16, 2023
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
force-pushed
the
trop/24-x-y-bp-fix-enable-browserwindow-id-access-post-destruction-1684222161052
branch
from
0683d3e
to
4eb95bf
Compare
codebytere
deleted the
trop/24-x-y-bp-fix-enable-browserwindow-id-access-post-destruction-1684222161052
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #38241
See that PR for details.
Notes: Fixed an issue where accessing
BrowserWindow.idthrew an error after the window was destroyed.