Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isMaximized after minimize/fullscreen on macOS #38306

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 16, 2023

Backport of #38291

See that PR for details.

Notes: Fixed an issue where BrowserWindow.isMaximized() could incorrectly return true for minimized or fullscreened windows on macOS.

@trop trop bot requested a review from codebytere May 16, 2023 07:27
@trop trop bot added 23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 16, 2023
@codebytere codebytere force-pushed the trop/23-x-y-bp-fix-ismaximized-after-minimize-fullscreen-on-macos-1684222020017 branch from 03fbee9 to 8f78fb2 Compare May 16, 2023 09:17
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@jkleinsc jkleinsc force-pushed the trop/23-x-y-bp-fix-ismaximized-after-minimize-fullscreen-on-macos-1684222020017 branch from 8f78fb2 to 72cfd9b Compare May 16, 2023 20:58
@codebytere codebytere merged commit f33a5c7 into 23-x-y May 17, 2023
13 checks passed
@codebytere codebytere deleted the trop/23-x-y-bp-fix-ismaximized-after-minimize-fullscreen-on-macos-1684222020017 branch May 17, 2023 08:20
@release-clerk
Copy link

release-clerk bot commented May 17, 2023

Release Notes Persisted

Fixed an issue where BrowserWindow.isMaximized() could incorrectly return true for minimized or fullscreened windows on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant