Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: printing crash when settings invalid #38230

Merged
merged 1 commit into from May 9, 2023
Merged

fix: printing crash when settings invalid #38230

merged 1 commit into from May 9, 2023

Conversation

codebytere
Copy link
Member

Backport of #38165

Notes: Fixed a potential crash when calling webContents.print with invalid settings.

@trop @codebytere
fix: printing crash when settings invalid
21fe474 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere requested a review from a team May 9, 2023 11:02
@codebytere codebytere requested a review from a team as a code owner May 9, 2023 11:02
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 9, 2023
@trop trop bot added 25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 9, 2023
@trop trop bot mentioned this pull request May 9, 2023
Merged
3 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 9, 2023
@jkleinsc jkleinsc merged commit e30b252 into 25-x-y May 9, 2023
13 checks passed
@jkleinsc jkleinsc deleted the trop/25-x-y-bp-fix-printing-crash-when-settings-invalid-1683205868767 branch May 9, 2023 16:16
@release-clerk
Copy link

release-clerk bot commented May 9, 2023

Release Notes Persisted

Fixed a potential crash when calling webContents.print with invalid settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc