Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: net.resolveHost #38152

Merged
merged 1 commit into from May 8, 2023
Merged

feat: net.resolveHost #38152

merged 1 commit into from May 8, 2023

Conversation

codebytere
Copy link
Member

Backport of #37853.

See that PR for details.

Notes: Add net.resolveHost that resolves hosts using defaultSession object

@codebytere codebytere requested a review from a team May 2, 2023 09:44
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 2, 2023
@trop trop bot mentioned this pull request May 2, 2023
Merged
5 tasks
@trop trop bot added 25-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels May 2, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 2, 2023
@codebytere codebytere changed the title feat: net.resolveHost feat: net.resolveHost May 2, 2023
VerteDinde
VerteDinde approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @electron/wg-releases

@codebytere codebytere merged commit 36d5706 into 25-x-y May 8, 2023
13 of 14 checks passed
@codebytere codebytere deleted the feature/net-resolveHost-25 branch May 8, 2023 07:46
@release-clerk
Copy link

release-clerk bot commented May 8, 2023

Release Notes Persisted

Add net.resolveHost that resolves hosts using defaultSession object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
25-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @VerteDinde @indutny