Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow usage of an absolute path for partitions used in a session #37604

Merged
merged 2 commits into from
Mar 20, 2023
Merged

feat: Allow usage of an absolute path for partitions used in a session #37604

merged 2 commits into from
Mar 20, 2023

Conversation

gecko19
Copy link
Contributor

@gecko19 gecko19 commented Mar 16, 2023

Description of Change
Allow an absolute path to be passed to the session.fromPath() API.
This allows multiple browser windows to be created with absolute paths specified in the session.fromPath() parameters.

Checklist

Release Notes
notes: Allows an absolute path to be passed to the session.fromPath() API.

@gecko19
Allow an absolute path to be used for creating sessions
5c09602 
Allows an absolute path to be used for creating sessions
by adding the session.fromPath() API.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 16, 2023
@gecko19
Copy link
Contributor Author

gecko19 commented Mar 16, 2023 •
edited

Hello @zcbenz, @jkleinsc and @codebytere.
I have created this new MR based on the older MR #36728 to avoid the rebase issue seen.

Please do approve and land this commit. I will close the older MR once this has landed.
Hope this is ok.
Thanks,
George.

ajafff
ajafff reviewed Mar 19, 2023
View reviewed changes
docs/api/session.md Outdated Show resolved Hide resolved
zcbenz
zcbenz approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@zcbenz zcbenz added semver/minor backwards-compatible functionality no-backport labels Mar 20, 2023
@zcbenz zcbenz mentioned this pull request Mar 20, 2023
Closed
5 tasks
jkleinsc
jkleinsc approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc
Copy link
Contributor

Merging as this is simply a redo of #36728

@jkleinsc jkleinsc merged commit e0c348a into electron:main Mar 20, 2023
@welcome
Copy link

welcome bot commented Mar 20, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Mar 20, 2023

Release Notes Persisted

Allows an absolute path to be passed to the session.fromPath() API.

@commit-lint commit-lint bot mentioned this pull request Jun 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajafff ajafff ajafff left review comments

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
api-review/requested 🗳 new-pr 🌱 PR opened in the last 24 hours no-backport semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gecko19 @jkleinsc @zcbenz @ajafff