fix: invoke app.dock.{hide|show} instead of duplicating logic
#37599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
ckerr
reviewed
Mar 16, 2023
| if (visibleOnFullScreen) { | ||
| [window_ setCanHide:NO]; | ||
| TransformProcessType(&psn, kProcessTransformToUIElementApplication); | ||
| Browser::Get()->DockHide(); |
There was a problem hiding this comment.
👍 on reusing the workarounds found in DockHide() / DockShow() here.
This diff has a subtle change: instead of calling NSWindow setCanHide:NO] for just window_, Browser::DockHide() calls it for everything in WindowList::GetWindows(). Is that OK / intentional here?
There was a problem hiding this comment.
i'd say yes - imo the previous version (only doing it on window_) was incorrect
zcbenz
approved these changes
Mar 17, 2023
jkleinsc
approved these changes
Mar 20, 2023
|
Release Notes Persisted
|
This was referenced Mar 20, 2023
|
I have automatically backported this PR to "22-x-y", please check out #37623 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
|
I have automatically backported this PR to "23-x-y", please check out #37624 |
|
I have automatically backported this PR to "24-x-y", please check out #37625 |
trop
bot
added
in-flight/23-x-y
merged/24-x-y
trop
bot
added
merged/23-x-y
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37487.
Fixes an issue with potential dock icon duplication on macOS by calling into our existing
app.dock.showandapp.dock.hideimplementations, which are also subject to the duplication bugs but include workarounds to prevent them from happening.Tested with https://gist.github.com/PsychoLlama/fcb2790372b6e4957beac9be7e543d3d to verify no duplicates occur.
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue with potential dock icon duplication on macOS.