fix: properly bubble up cookie creation failure message #37586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
improve-cookie-set-failure
branch
2 times, most recently
from
f081dbc
to
0b0fc23
Compare
codebytere
force-pushed
the
improve-cookie-set-failure
branch
from
0b0fc23
to
4c07a74
Compare
deepak1556
approved these changes
Mar 15, 2023
VerteDinde
approved these changes
Mar 15, 2023
|
Release Notes Persisted
|
This was referenced Mar 16, 2023
|
I have automatically backported this PR to "22-x-y", please check out #37595 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
|
I have automatically backported this PR to "23-x-y", please check out #37596 |
|
I have automatically backported this PR to "24-x-y", please check out #37597 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
trop
bot
added
merged/22-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37568.
net::CanonicalCookie::CreateSanitizedCookieallows for passing anet::CookieInclusionStatusout parameter, which will contain errors related to cookie creation if they existed. Previously, if the cookie wasn't created we showed the user a generic failure, but we should instead show the user the more specific error should it exist.Checklist
npm testpassesRelease Notes
Notes: Improve error messages on
session.cookies.setfailure.