Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify open-url not preventable #37564

Merged
merged 1 commit into from
Mar 14, 2023
Merged

docs: clarify open-url not preventable #37564

merged 1 commit into from
Mar 14, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 13, 2023 •
edited

Description of Change

Closes #37495.

Clarifies that open-url is not in fact preventable and has never been.

Checklist

Release Notes

Notes: none.

@codebytere codebytere added documentation 📓 semver/patch backwards-compatible bug fixes target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. labels Mar 13, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 13, 2023
@codebytere codebytere changed the title docs: clarify open-url not preventable docs: clarify open-url not preventable Mar 13, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 14, 2023
@codebytere codebytere merged commit e480cb7 into main Mar 14, 2023
@codebytere codebytere deleted the fix-open-url branch March 14, 2023 13:17
@release-clerk
Copy link

release-clerk bot commented Mar 14, 2023

No Release Notes

This was referenced Mar 14, 2023
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Mar 14, 2023

I have automatically backported this PR to "23-x-y", please check out #37573

@trop trop bot added in-flight/23-x-y and removed target/23-x-y PR should also be added to the "23-x-y" branch. labels Mar 14, 2023
@trop
Copy link
Contributor

trop bot commented Mar 14, 2023

I have automatically backported this PR to "22-x-y", please check out #37574

@trop
Copy link
Contributor

trop bot commented Mar 14, 2023

I have automatically backported this PR to "24-x-y", please check out #37575

@trop trop bot added in-flight/22-x-y merged/24-x-y PR was merged to the "24-x-y" branch merged/22-x-y PR was merged to the "22-x-y" branch. and removed target/22-x-y PR should also be added to the "22-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. in-flight/24-x-y labels Mar 14, 2023
@trop trop bot added merged/23-x-y PR was merged to the "23-x-y" branch. and removed in-flight/22-x-y labels Mar 15, 2023
@commit-lint commit-lint bot mentioned this pull request Jun 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
documentation 📓 merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Window showing on 'open-url' with preventDefault()
2 participants
@codebytere @VerteDinde