-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fallback to X11 capturer if pipewire fails on Wayland #37511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
changed the title
Fallback x11 capturer wayland
fix: fallback to X11 capturer if pipewire fails on Wayland
Mar 6, 2023
VerteDinde
added
semver/patch
backwards-compatible bug fixes
target/23-x-y
PR should also be added to the "23-x-y" branch.
target/24-x-y
PR should also be added to the "24-x-y" branch.
labels
Mar 6, 2023
vially
reviewed
Mar 6, 2023
georgexu99
approved these changes
Mar 6, 2023
MarshallOfSound
approved these changes
Mar 6, 2023
3 tasks
Release Notes Persisted
|
This was referenced Mar 7, 2023
I have automatically backported this PR to "23-x-y", please check out #37526 |
trop
bot
added
in-flight/23-x-y
and removed
target/23-x-y
PR should also be added to the "23-x-y" branch.
labels
Mar 7, 2023
I have automatically backported this PR to "24-x-y", please check out #37527 |
trop
bot
added
in-flight/24-x-y
merged/23-x-y
PR was merged to the "23-x-y" branch.
merged/24-x-y
PR was merged to the "24-x-y" branch
and removed
target/24-x-y
PR should also be added to the "24-x-y" branch.
in-flight/23-x-y
labels
Mar 7, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged/23-x-y
PR was merged to the "23-x-y" branch.
merged/24-x-y
PR was merged to the "24-x-y" branch
semver/patch
backwards-compatible bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #37463
Desktop Capturer behaves inconsistently on Wayland. We use PipeWire within WebRTC on Wayland to gather desktop window & screen capture sources. However, PipeWire does not always successfully start, and beginning with this CL, we no longer fall back to the X11 capturer, even if it is enabled: https://webrtc-review.googlesource.com/c/src/+/279163
Currently if neither PipeWire or X11 can be used, we return a nullptr in place of the capturer sources, crashing the application.
This PR does two things:
DesktopCapturer::StartHandling
method. (Thanks @ckerr!)Checklist
npm test
passesRelease Notes
Notes: Fixed a crash on capturing sources when using desktopCapturer API on Wayland.