Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't double-log unhandled rejections #37502

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 6, 2023

Backport of #37464

See that PR for details.

Notes: Fixed an issue where unhandled rejections could cause duplicate logs in some cases.

@trop trop bot requested a review from codebytere March 6, 2023 10:06
@trop trop bot mentioned this pull request Mar 6, 2023
4 tasks
@trop trop bot added 22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 6, 2023
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere force-pushed the trop/22-x-y-bp-fix-don-t-double-log-unhandled-rejections-1678097140923 branch from bc5987f to 06bc492 Compare March 6, 2023 13:36
@codebytere codebytere merged commit d44fd39 into 22-x-y Mar 7, 2023
@codebytere codebytere deleted the trop/22-x-y-bp-fix-don-t-double-log-unhandled-rejections-1678097140923 branch March 7, 2023 20:35
@release-clerk
Copy link

release-clerk bot commented Mar 7, 2023

Release Notes Persisted

Fixed an issue where unhandled rejections could cause duplicate logs in some cases.

vikunja-bot pushed a commit to go-vikunja/desktop that referenced this pull request Mar 16, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [electron](https://github.com/electron/electron) | devDependencies | patch | [`23.1.3` -> `23.1.4`](https://renovatebot.com/diffs/npm/electron/23.1.3/23.1.4) |

---

### Release Notes

<details>
<summary>electron/electron</summary>

### [`v23.1.4`](https://github.com/electron/electron/releases/tag/v23.1.4): electron v23.1.4

[Compare Source](electron/electron@v23.1.3...v23.1.4)

### Release Notes for v23.1.4

#### Fixes

-   Fixed an issue where unhandled rejections could cause duplicate logs in some cases. [#&#8203;37501](electron/electron#37501) <span style="font-size:small;">(Also in [22](electron/electron#37502), [24](https://github.com/electron/electron/pull/37500))</span>

#### Other Changes

-   Updated Chromium to 110.0.5481.192. [#&#8203;37533](electron/electron#37533)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1Ny4wIn0=-->

Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/142
Co-authored-by: renovate <renovatebot@kolaente.de>
Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant