fix: Notification with reply obscuring first action on macOS
#37447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
3 tasks
trop
bot
added
22-x-y
backport
codebytere
approved these changes
Mar 1, 2023
codebytere
deleted the
trop/22-x-y-bp-fix-notification-with-reply-obscuring-first-action-on-macos-1677660433107
branch
|
Release Notes Persisted
|
vikunja-bot
pushed a commit
to go-vikunja/desktop
that referenced
this pull request
Mar 3, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [electron](https://github.com/electron/electron) | devDependencies | patch | [`23.1.1` -> `23.1.2`](https://renovatebot.com/diffs/npm/electron/23.1.1/23.1.2) | --- ### Release Notes <details> <summary>electron/electron</summary> ### [`v23.1.2`](https://github.com/electron/electron/releases/tag/v23.1.2) [Compare Source](electron/electron@v23.1.1...v23.1.2) ### Release Notes for v23.1.2 #### Fixes - Fixed `destroyed` event not emitted on `close` for `BrowserView.webContents`. [#​37451](electron/electron#37451) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37450))</span> - Fixed an incorrect result returned when using secure as a cookies filter. [#​37248](electron/electron#37248) <span style="font-size:small;">(Also in [22](electron/electron#37247), [24](https://github.com/electron/electron/pull/37246))</span> - Fixed an issue where `minWidth`/`minHeight` and `maxWidth`/`maxHeight` would not be enforced if the user set an `aspectRatio` on macOS. [#​37457](electron/electron#37457) <span style="font-size:small;">(Also in [22](electron/electron#37458), [24](https://github.com/electron/electron/pull/37456))</span> - Fixed an issue where passing both `hasReply` and `actions` to a main process Notification on macOS resulted in the first action being obscured and unavailable. [#​37448](electron/electron#37448) <span style="font-size:small;">(Also in [22](electron/electron#37447), [24](https://github.com/electron/electron/pull/37449))</span> - Fixed draggable regions not working in Mac App Store builds. [#​37473](electron/electron#37473) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37474))</span> - Fixed right-click events not being delivered in frameless window draggable regions. [#​37394](electron/electron#37394) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37395))</span> #### Other Changes - Improved error messages for `contents.takeHeapSnapshot`. [#​37460](electron/electron#37460) <span style="font-size:small;">(Also in [22](electron/electron#37459), [24](https://github.com/electron/electron/pull/37461))</span> - Updated Chromium to 110.0.5481.177. [#​37389](electron/electron#37389) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDAuMiIsInVwZGF0ZWRJblZlciI6IjMyLjI0MC4yIn0=--> Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/140 Co-authored-by: renovate <renovatebot@kolaente.de> Co-committed-by: renovate <renovatebot@kolaente.de>
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #37381
See that PR for details.
Notes: Fixes an issue where passing both
hasReplyandactionsto a main process Notification on macOS resulted in the first action being obscured and unavailable.