Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BroadcastChannel initialization location #37421

Merged
merged 2 commits into from
Feb 28, 2023
Merged

fix: BroadcastChannel initialization location #37421

merged 2 commits into from
Feb 28, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Feb 27, 2023 •
edited

Description of Change

Closes #37417.
Refs nodejs/node#40532.

Fixes a bug wherein BroadcastChannel should have been initialized in lib/internal/bootstrap/browser.js instead of lib/internal/bootstrap/node.js. That inadvertently made it such that there was incorrect handling of the DOM vs Node.js implementations of BroadcastChannel.

Tested with https://gist.github.com/dfahlander/cb9dfccd6e32101843800feade72049c

Checklist

Release Notes

Notes: Fixed an issue where BroadcastChannel did not work correctly when contextIsolation: false.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. labels Feb 27, 2023
@codebytere codebytere requested a review from a team as a code owner February 27, 2023 12:01
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 27, 2023
@codebytere codebytere mentioned this pull request Feb 27, 2023
Merged
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 28, 2023
@jkleinsc jkleinsc merged commit 87f2a1d into main Feb 28, 2023
@jkleinsc jkleinsc deleted the fix-broadcast-channel branch February 28, 2023 22:26
@release-clerk
Copy link

release-clerk bot commented Feb 28, 2023

Release Notes Persisted

Fixed an issue where BroadcastChannel did not work correctly when contextIsolation: false.

This was referenced Feb 28, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Feb 28, 2023

I have automatically backported this PR to "24-x-y", please check out #37443

@trop
Copy link
Contributor

trop bot commented Feb 28, 2023

I have automatically backported this PR to "23-x-y", please check out #37444

@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. labels Feb 28, 2023
@dfahlander dfahlander mentioned this pull request Mar 1, 2023
Closed
@trop trop bot added merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/24-x-y labels Mar 1, 2023
@trop trop bot added the merged/23-x-y PR was merged to the "23-x-y" branch. label Mar 16, 2023
@trop trop bot removed the in-flight/23-x-y label Mar 16, 2023
@commit-lint commit-lint bot mentioned this pull request May 25, 2023
Open
@serdaryesilmurat
Copy link

37417 is not fixed.
Refer to comment.

codebytere added a commit that referenced this pull request Sep 29, 2023
@codebytere @patchup
fix: BroadcastChannel initialization location (#37421)
842ec8b 
* fix: BroadcastChannel initialization location

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
@codebytere codebytere mentioned this pull request Sep 29, 2023
Merged
3 tasks
codebytere added a commit that referenced this pull request Oct 2, 2023
@codebytere @patchup
fix: BroadcastChannel initialization location (#40049)
93bcb30 
fix: `BroadcastChannel` initialization location (#37421)

* fix: BroadcastChannel initialization location

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
trop bot added a commit that referenced this pull request Oct 2, 2023
@trop @codebytere
fix: BroadcastChannel initialization location (#37421)
ccbd51a 
* fix: BroadcastChannel initialization location

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
trop bot added a commit that referenced this pull request Oct 2, 2023
@trop @codebytere
fix: BroadcastChannel initialization location (#37421)
d115cf8 
* fix: BroadcastChannel initialization location

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere added a commit that referenced this pull request Oct 2, 2023
@trop @codebytere
fix: BroadcastChannel initialization location (#40067)
9e8cba9 
fix: `BroadcastChannel` initialization location (#37421)

* fix: BroadcastChannel initialization location

* chore: update patches

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere added a commit that referenced this pull request Oct 2, 2023
@trop @codebytere
fix: BroadcastChannel initialization location (#40066)
a55c4c6 
fix: `BroadcastChannel` initialization location (#37421)

* fix: BroadcastChannel initialization location

* chore: update patches

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere @patchup
fix: BroadcastChannel initialization location (electron#40049)
3507284 
fix: `BroadcastChannel` initialization location (electron#37421)

* fix: BroadcastChannel initialization location

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: BroadcastChannel support broken in version 23
6 participants
@codebytere @serdaryesilmurat @nornagon @VerteDinde @MarshallOfSound @jkleinsc