Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logUsage to shell.openExternal() options #37291

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 16, 2023

Backport of #37139

See that PR for details.

Notes: Added logUsage to shell.openExternal() options, which allows passing the SEE_MASK_FLAG_LOG_USAGE flag to ShellExecuteEx on Windows.

Co-authored-by: Milan Burda <miburda@microsoft.com>
@trop trop bot requested a review from miniak February 16, 2023 01:55
@trop trop bot added 24-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Feb 16, 2023
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases!

@codebytere codebytere merged commit a6a8622 into 24-x-y Feb 27, 2023
@codebytere codebytere deleted the trop/24-x-y-bp-feat-add-logusage-to-shell-openexternal-options-1676512531667 branch February 27, 2023 09:02
@release-clerk
Copy link

release-clerk bot commented Feb 27, 2023

Release Notes Persisted

Added logUsage to shell.openExternal() options, which allows passing the SEE_MASK_FLAG_LOG_USAGE flag to ShellExecuteEx on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant