Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include all standard paper sizes for webContents.print() #37263

Merged
merged 1 commit into from
Feb 15, 2023
Merged

feat: include all standard paper sizes for webContents.print() #37263

merged 1 commit into from
Feb 15, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 14, 2023

Backport of #37159

See that PR for details.

Notes: Added several standard page size options to webContents.print().

@trop @codebytere
feat: include standard paper sizes for webContents.print()
c938830 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested a review from codebytere February 14, 2023 10:45
@trop trop bot mentioned this pull request Feb 14, 2023
Merged
4 tasks
@trop trop bot added 22-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Feb 14, 2023
VerteDinde
VerteDinde approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @electron/wg-releases

@codebytere codebytere merged commit 54436d2 into 22-x-y Feb 15, 2023
@codebytere codebytere deleted the trop/22-x-y-bp-feat-include-all-standard-paper-sizes-for-webcontents-print--1676371506285 branch February 15, 2023 18:59
@release-clerk
Copy link

release-clerk bot commented Feb 15, 2023

Release Notes Persisted

Added several standard page size options to webContents.print().

@Soltus Soltus mentioned this pull request Feb 16, 2023
Closed
@aimane-chnaif aimane-chnaif mentioned this pull request Mar 17, 2023
Merged
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
22-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VerteDinde @codebytere