feat: add httpOnly cookies.get filter
#37255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Feb 14, 2023
codebytere
changed the title
httpOnly cookies filter
codebytere
changed the title
httpOnly cookies filterhttpOnly cookies.get filter
codebytere
added
target/23-x-y
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
|
Release Notes Persisted
|
|
I was unable to backport this PR to "23-x-y" cleanly; |
trop
bot
added
needs-manual-bp/23-x-y
and removed
target/23-x-y
|
I have automatically backported this PR to "24-x-y", please check out #37365 |
trop
bot
added
in-flight/24-x-y
and removed
target/24-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
feat: add httpOnly cookies filter
trop
bot
added
merged/24-x-y
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
feat: add httpOnly cookies filter
BlackHole1
added a commit
to BlackHole1/electron
that referenced
this pull request
Apr 20, 2023
feat: add httpOnly cookies filter
|
@BlackHole1 has manually backported this PR to "23-x-y", please check out #38043 |
trop
bot
added
in-flight/23-x-y
merged/23-x-y
jkleinsc
pushed a commit
that referenced
this pull request
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The existing filter does not fully cover some scenarios, such as
httpOnly. ThishttpOnlyfilter can avoid additional judgments at the js level.Checklist
npm testpassesRelease Notes
Notes: Add
httpOnlyto the cookie filter.