feat: add will-frame-navigate event
#34418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
reviewed
Jun 2, 2022
zcbenz
reviewed
Jun 2, 2022
itsananderson
force-pushed
the
add-will-frame-navigate
branch
from
c09f15e
to
26f1ceb
Compare
|
Is there a possibility that this PR will be reviewed / merged soon? |
|
I'm actually working on updating my branch this week. The |
itsananderson
force-pushed
the
add-will-frame-navigate
branch
from
26f1ceb
to
f25f7b5
Compare
|
API LGTM |
jkleinsc
approved these changes
Mar 28, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "24-x-y" cleanly; |
trop
bot
added
needs-manual-bp/24-x-y
and removed
target/24-x-y
|
Thanks everyone :-) |
miniak
pushed a commit
that referenced
this pull request
Apr 11, 2023
miniak
pushed a commit
that referenced
this pull request
Apr 11, 2023
miniak
pushed a commit
that referenced
this pull request
Apr 11, 2023
miniak
pushed a commit
that referenced
this pull request
Apr 11, 2023
miniak
pushed a commit
that referenced
this pull request
Apr 12, 2023
miniak
pushed a commit
that referenced
this pull request
Apr 12, 2023
miniak
pushed a commit
that referenced
this pull request
Apr 12, 2023
miniak
pushed a commit
that referenced
this pull request
Apr 12, 2023
miniak
pushed a commit
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds a
will-frame-navigateevent towebContents. Unlikewill-navigatewhich only fires for the mainFrame, this event fires for any frames within thewebContents. Similarly, awill-frame-navigateattribute is added to the<webview>tag, which is called whenever that webview or any of its child frames attempts to navigate.Because
will-navigateandwill-frame-navigateare so similar, I mostly copied the tests fromwill-navigateand updated them to test the correct event. I also added some additional tests forwill-frame-navigateto verify the correct behavior when a subframe navigates.Closes #7097
cc @samuelmaddock who has discussed adding this event in the past
Checklist
npm testpassesRelease Notes
Notes: Added a
will-frame-navigateevent towebContentsand the<webview>tag, which fires whenever any frame within the frame hierarchy attempts to navigate.