test: disable CapturableScreen tests on Windows x64 (#41544)

* test: disable CapturableScreen tests on Windows x64 (cherry picked from commit 60a288a) * test: disable js-execute-iframe" case should not crash on win 32-bit (cherry picked from commit d545ae0)
electron · Mar 8, 2024 · 33e61a1 · 33e61a1
1 parent a90c5b1
commit 33e61a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/spec/crash-spec.ts b/spec/crash-spec.ts
@@ -40,9 +40,13 @@ const shouldRunCase = (crashCase: string) => {
     case 'quit-on-crashed-event': {
       return (process.platform !== 'win32' || process.arch !== 'ia32');
     }
-    // TODO(jkleinsc) fix this test on Linux on arm/arm64
+    // TODO(jkleinsc) fix this test on Linux on arm/arm64 and 32bit windows
     case 'js-execute-iframe': {
-      return (process.platform !== 'linux' || (process.arch !== 'arm64' && process.arch !== 'arm'));
+      if (process.platform === 'win32') {
+        return process.arch !== 'ia32';
+      } else {
+        return (process.platform !== 'linux' || (process.arch !== 'arm64' && process.arch !== 'arm'));
+      }
     }
     default: {
       return true;

diff --git a/spec/lib/screen-helpers.ts b/spec/lib/screen-helpers.ts
@@ -99,8 +99,8 @@ export const areColorsSimilar = (
  * - Linux: virtual screen display is 0x0
  * - Win32 arm64 (WOA): virtual screen display is 0x0
  * - Win32 ia32: skipped
+ * - Win32 x64: virtual screen display is 0x0
  */
 export const hasCapturableScreen = () => {
-  return process.platform === 'darwin' ||
-    (process.platform === 'win32' && process.arch === 'x64');
+  return process.platform === 'darwin';
 };