Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mac): sign NSIS on mac #8090

Merged
merged 2 commits into from Mar 2, 2024
Merged

fix(mac): sign NSIS on mac #8090

merged 2 commits into from Mar 2, 2024

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Mar 2, 2024

Revert "fix(win): use resultOutputPath to sign custom location for windows (#7919)". The property resultOutputPath is not meant to be overridden externally during the sign hook, other internal app-builder-lib logic explicitly depends on it for when the host machine is not Windows.

This reverts commit 4e930a7.

Fixes: #7973

Copy link

changeset-bot bot commented Mar 2, 2024

🦋 Changeset detected

Latest commit: db1c77b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit db1c77b
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65e2db827b47e700086178af
😎 Deploy Preview https://deploy-preview-8090--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 2c147ad into master Mar 2, 2024
15 checks passed
@mmaietta mmaietta deleted the fix/mac-signing-2 branch March 2, 2024 08:05
@github-actions github-actions bot mentioned this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to sign NSIS
1 participant