Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(msi): build emulated arm64 MSI installers as stopgap until electron-builder-binaries wix version is updated #8086

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix(msi): build emulated arm64 MSI installers as stopgap until electron-builder-binaries wix version is updated #8086

merged 1 commit into from
Mar 1, 2024

Commits on Feb 29, 2024

  1. feat(msi): build emulated arm64 MSI installers 

    Build x64 MSI installers when targeting the arm64 architecture. This
results in an x64 MSI installer that installs an arm64 version of the
application.

An x64 MSI installer is an improvement because building arm64 MSI
targets errors with:
```
error CNDL0264 : The parameter 'arch' is missing or has an invalid value arm64.
Possible values are x86, x64, or ia64.
```

This is a stopgap until the electron-builder-binaries wix version is upgraded
to a version that supports arm64 which is currently blocked by a number of
breaking changes between 4.0.0.5512.2 and 4.0.1. This upgrade is
discussed in electron-userland#6077.
    @Allan-Kerr
    Allan-Kerr committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c3937e2 View commit details
    Browse the repository at this point in the history