Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hooks resolveModule default fallback to require #8042

Merged
merged 4 commits into from Feb 9, 2024

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Feb 9, 2024

Attempt dynamically importing hook as a module if package.json type=module, if fail, fallback to default require

Fixes: #8036

Copy link

changeset-bot bot commented Feb 9, 2024

🦋 Changeset detected

Latest commit: 9f479e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 9f479e3
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65c576e576348a000889b24f
😎 Deploy Preview https://deploy-preview-8042--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 63a0044 into master Feb 9, 2024
14 checks passed
@mmaietta mmaietta deleted the fix/hooks-require-fallback branch February 9, 2024 17:06
@github-actions github-actions bot mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES module resolution fails when using main entrypoint in package.json
1 participant