Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass publish options to snap publisher #7908

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

Rychu-Pawel
Copy link
Contributor

This fixes #7907 "The channels option from SnapStoreOptions is not applied when publishing using Snapcraft"

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: c2e39d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit c2e39d0
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65677853d388b7000846fa5f
😎 Deploy Preview https://deploy-preview-7908--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rychu-Pawel Rychu-Pawel changed the title Fixed passing publish options to snap publisher fix: pass publish options to snap publisher Nov 29, 2023
@mmaietta
Copy link
Collaborator

There are some build errors and formatting issues when I checked this out locally. Also need to generate a changeset for the CI/CD automation to pick it up for release.
Can you please give permissions to me to add changes to this PR? I have the formatting+changeset ready to push but I'm getting a "repository not found" error

@Rychu-Pawel
Copy link
Contributor Author

Rychu-Pawel commented Nov 29, 2023

@mmaietta invite sent and thanks for the changes

@mmaietta mmaietta merged commit 9fc5157 into electron-userland:master Nov 29, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The channels option from SnapStoreOptions is not applied when publishing using Snapcraft
3 participants