fix: default downloaded file name

[marcuskirsch]

Fix default file name of update.${fileExtension} for downloaded files in private repositories.

Should fix:

• Electron Updater changes file name top updater.appImage. GH_Token not found when set in enviroment #7022
• Auto update on linux changes file name to update.appimage #5477
• Auto update rename AppImage #5239
• Auto update on linux changes file name to update.appimage #3664
• AutoUpdater creates the update.AppImage file instead of replacing it #3639

[changeset-bot]

🦋 Changeset detected

Latest commit: 7097f3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
electron-updater	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name	Link
🔨 Latest commit	7097f3e
🔍 Latest deploy log	https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6479ba9351f6b70008b5fe44
😎 Deploy Preview	https://deploy-preview-7597--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[mmaietta]

Just to double-check. How have you been testing/deploying this change locally?

I'm trying to understand what this change is doing here. Why can't it be update.AppImage? This change is affecting all downloaded updates

For AppImages, it's already supposed to be reusing the original name of the installed AppImage.

electron-builder/packages/electron-updater/src/AppImageUpdater.ts

Lines 86 to 94 in e3fc9b5

	const existingBaseName = path.basename(appImageFile)
	// https://github.com/electron-userland/electron-builder/issues/2964
	// if no version in existing file name, it means that user wants to preserve current custom name
	if (path.basename(options.installerPath) === existingBaseName || !/\d+\.\d+\.\d+/.test(existingBaseName)) {
	// no version in the file name, overwrite existing
	destination = appImageFile
	} else {
	destination = path.join(path.dirname(appImageFile), path.basename(options.installerPath))
	}

[marcuskirsch]

Just to double-check. How have you been testing/deploying this change locally?

I'm trying to understand what this change is doing here. Why can't it be update.AppImage? This change is affecting all downloaded updates

For AppImages, it's already supposed to be reusing the original name of the installed AppImage.

electron-builder/packages/electron-updater/src/AppImageUpdater.ts

Lines 86 to 94 in e3fc9b5

	const existingBaseName = path.basename(appImageFile)
	// https://github.com/electron-userland/electron-builder/issues/2964
	// if no version in existing file name, it means that user wants to preserve current custom name
	if (path.basename(options.installerPath) === existingBaseName || !/\d+\.\d+\.\d+/.test(existingBaseName)) {
	// no version in the file name, overwrite existing
	destination = appImageFile
	} else {
	destination = path.join(path.dirname(appImageFile), path.basename(options.installerPath))
	}

I have not seen this part of the code. But you should call the AppImage not update.AppImage but like it is in the latest-linux.yml? When I do an update, for example, XY-1.4.9.AppImage is renamed to update.AppImage.After that, no one knows what is behind the AppImage.

I tested this locally for Linux.

[mmaietta]

I like this change! 👍

Just to confirm, have you tested this on Mac + Windows?

[marcuskirsch]

@mmaietta Unfortunately, I don't have the possibility to test it in other environments. Could you? Pleeaaaase…

[marcuskirsch]

@mmaietta i tested it in some virtual machines. Everything works like expected. I guess you can approve that little puppy. ;)