Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use the content-length HTTP header to check size of data #7544

Merged

Conversation

NoahAndrews
Copy link
Contributor

Fixes #7543

content-length will differ from the actual size of the data if the HTTP response was compressed.
@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2023

🦋 Changeset detected

Latest commit: f2d9aa0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
builder-util-runtime Patch
electron-updater Patch
app-builder-lib Patch
builder-util Patch
dmg-builder Patch
electron-builder Patch
electron-publish Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit f2d9aa0
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/643893cfcaea070008cb4aec
😎 Deploy Preview https://deploy-preview-7544--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta changed the title Don't use the content-length HTTP header to check size of data fix: Don't use the content-length HTTP header to check size of data Apr 15, 2023
@mmaietta mmaietta merged commit dab3aeb into electron-userland:master Apr 15, 2023
13 of 14 checks passed
@github-actions github-actions bot mentioned this pull request Apr 15, 2023
@NoahAndrews NoahAndrews deleted the dont-use-content-length branch April 16, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differential downloads don't work when the blockmap HTTP response is compressed
2 participants