Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nsis): display "Space required" text for NSIS installer #7531

Conversation

inickvel
Copy link
Contributor

@inickvel inickvel commented Apr 10, 2023

Implements #7487

Used NSIS SectionSetSize function to set correct space.

image

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023

🦋 Changeset detected

Latest commit: d1aecea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
app-builder-lib Minor
builder-util Minor
dmg-builder Minor
electron-builder-squirrel-windows Minor
electron-builder Minor
electron-forge-maker-appimage Minor
electron-forge-maker-nsis-web Minor
electron-forge-maker-nsis Minor
electron-forge-maker-snap Minor
electron-publish Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit d1aecea
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/643d44d0e291cf00084562d2
😎 Deploy Preview https://deploy-preview-7531--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@inickvel inickvel changed the title feat(nsis): display required disk space feat(nsis): display "Space required" text for NSIS installer Apr 10, 2023
@mmaietta
Copy link
Collaborator

Please add a changeset via pnpm generate-changeset so that this PR gets picked up automatically by the release automation workflow.

@mmaietta
Copy link
Collaborator

Tests are throwing an error:

    Processing script file: "<stdin>" (UTF8)
    warning 6000: unknown variable/constant "{SYSTYPE_PTR}" detected, ignoring (installSection.nsh:31)

Nikolay Velizhanin added 2 commits April 17, 2023 13:35
@inickvel
Copy link
Contributor Author

Please add a changeset via pnpm generate-changeset so that this PR gets picked up automatically by the release automation workflow.

Done

Fixed warning 6000 unknown variable/constant "{SYSTYPE_PTR}" detected

electron-userland#7487
@inickvel
Copy link
Contributor Author

Tests are throwing an error:

    Processing script file: "<stdin>" (UTF8)
    warning 6000: unknown variable/constant "{SYSTYPE_PTR}" detected, ignoring (installSection.nsh:31)

Fixed

@inickvel
Copy link
Contributor Author

inickvel commented Apr 17, 2023

@mmaietta Fixed all comments. Could you check the PR again, please? )

@mmaietta mmaietta merged commit 0db9c66 into electron-userland:master Apr 17, 2023
13 checks passed
@mmaietta
Copy link
Collaborator

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants