Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introducing deb and rpm auto-updates #7060

Merged
merged 10 commits into from Nov 27, 2022
Merged

Conversation

mmaietta
Copy link
Collaborator

[Draft]
Utilizes GUI-based sudo for installation which is pulled via which gksudo || which kdesudo || which pkexec || which beesu and executed using /bin/bash -c in order to coalesce all commands under a single sudo prompt
Deb is fairly straightforward and evals to this:

`which dnf || which yum` -i path-to-update.deb || apt-get install --fix-broken -y

Rpm requires one of these package managers available: zypper, dnf, yum

zypper -y remove AppName; zypper -y install path-to-update.rpm

js is optimized, but the shell cmd basically is:

`which dnf || which yum` remove -y AppName;
`which dnf || which yum` clean --all;
`which dnf || which yum` --no-refresh install --allow-unsigned-rpm -y -f path-to-update.rpm

Testing still in progress on Ubuntu 14/18/20/22 and Fedora 32. No clue what else to test on, suggestions would be appreciated

Things I could use help/verification on:

  • idk if --allow-unsigned-rpm is a good idea, but that's what I use in my home project.
  • are those enough package managers to cover?

Note: This would need to go through a significant alpha version stage for electron-builder

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2022

🦋 Changeset detected

Latest commit: 18d2f3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
app-builder-lib Minor
electron-updater Minor
dmg-builder Minor
electron-builder-squirrel-windows Minor
electron-builder Minor
electron-forge-maker-appimage Minor
electron-forge-maker-nsis-web Minor
electron-forge-maker-nsis Minor
electron-forge-maker-snap Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 12, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 18d2f3d
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/637e6dff54daea00091b5b79
😎 Deploy Preview https://deploy-preview-7060--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta
Copy link
Collaborator Author

@develar what are your thoughts on this?

mmaietta and others added 2 commits October 24, 2022 22:45
# Conflicts:
#	packages/electron-updater/src/NsisUpdater.ts
@mmaietta mmaietta marked this pull request as ready for review November 23, 2022 19:01
@mmaietta mmaietta changed the title feat: Introducing deb and rpm auto-updates [WIP] feat: Introducing deb and rpm auto-updates Nov 23, 2022
@mmaietta mmaietta merged commit 1d13001 into master Nov 27, 2022
@mmaietta mmaietta deleted the feat/rpm-deb-updates branch November 27, 2022 18:01
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
@Kilian
Copy link
Contributor

Kilian commented Sep 4, 2023

I would love to configure this for my app but there's (seemingly) no documentation on how to set up autoupdating for .deb. What are the steps needed to support and test this?

@mmaietta
Copy link
Collaborator Author

mmaietta commented Sep 4, 2023

@Kilian it should be the exact same setup as when using AppImage, just need to add deb as a target in electron-builder config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants