-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove genUUID and unused useRandom hook #585
remove genUUID and unused useRandom hook #585
Conversation
dcceccb
to
73c010f
Compare
|
yep, pushed another commit right now. Checking if examples are still working (website is okay) |
Tested with Expo and React native to double-check that Had to fiddle with React Native to get the code working again. I initially thought that this was because of upgrading to Sonoma, but apparently it is a global issue: CocoaPods/CocoaPods#12081 I got things working for me. @kevin-dp @thruflo could one of you check that React Native is also broken for you. If yes, I'll provide instructions. |
|
451851f
to
90a5e52
Compare
90a5e52
to
c11ea92
Compare
Attempting to verify. If I can get an 8GB iOS Simulator upgrade down over pub wifi ... |
React Native works fine for me. |
Cool. No hassle installing ruby libraries? |
Only with my own Xcode tooling. |
Will be merging this since changes are not related with the instructions for React Native failing for me. Created a new issue to review React Native instructions with more recent version of cocoa pods. |
@thruflo still need an approval |
@balegas how can i run this? Because how it is configured it will use the published Electric image. If i do that i get errors. Should i run against a local build? But that's a bit tricky as it requires all the changes to expose the necessary ports. |
@kevin-dp not sure if I missed something, but the answer is the same way you tested applications before, because nothing changed. |
I don't think this works since we introduced the proxy and now the latest published image also uses the proxy but this app is not using the proxy. |
@samwillis pulling you in on this one after conversation yesterday. As you point out, we're overriding a global variable, so maybe we need to handle this better. We do that to ensure we use the right dep for the different envs. If we have one that works across that would simplify code. I think initially we decided not to go with a js-based approach because of higher collision rate. I'm happy with that tradeoff. If you wish to fix this as part of your refactoring, I'm very happy. Otherwise, leave a comment here so we can pick it up later. |
- Removed unused and undocumented `useRandom` hook which was originally already removed in this PR #585 but was added back with another refactor - Removed dependency on the injected electric client in `useLiveQuery`
Use of
crypto
was creating problems with some platforms. This was also redundant because we also define auuid()
function.