Replace Measurement and UnscaledMeasurement with explicit Acceleration and MagneticField structs.
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
explicit-structs
branch
from
474b7f6
to
e451306
Compare
eldruin
reviewed
Aug 7, 2022
There was a problem hiding this comment.
Nice improvements, thank you!
Overall it looks very good to me. I would just skip bitflags as described in the other issue.
Could you also:
- Add tests for the temperature enable/disable methods
- Add tests for the
rawversion of the measurement methods - Add an entry to the changelog?
|
Added tests for the |
eldruin
reviewed
Aug 8, 2022
There was a problem hiding this comment.
Looks good!
Could you also update the method list in the README as well?
Other than that this would be good to go.
Ugh, GH is showing a bunch of conflicts now that I merged #11 but git should be able to trivially merge them as I explicitly did not squash the commits.
…nd `MagneticField`.
reitermarkus
force-pushed
the
explicit-structs
branch
from
144c1c9
to
d692da6
Compare
eldruin
reviewed
Aug 8, 2022
eldruin
approved these changes
Aug 8, 2022
eldruin
reviewed
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the API by having only one method each for measuring, with the conversion (unscaled/mg/nT) being done by the explicit types.
Also included the changes from #11.