Fix Data Stream Lifecycle health indicator to return UNKNOWN #108812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no health info available from the health node, the status should be UNKNOWN instead of GREEN.
nielsbauman
added
>bug
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @nielsbauman, I've created a changelog YAML for you. |
nielsbauman
commented
May 20, 2024
| @Before | ||
| public void updatePollInterval() throws IOException { | ||
| // We need Data Stream Lifecycle to run at least once to have a "green" status. | ||
| updateClusterSettings(client(), Settings.builder().put("data_streams.lifecycle.poll_interval", "5s").build()); |
There was a problem hiding this comment.
After I added this fix, I realized that this PR will cause the health API to return unknown after cluster startup until Data Stream Lifecycle has run at least once. The default interval is 5m, which is quite a while for the health API to report unknown IMO. It probably makes sense to discuss this briefly before we proceed.
|
During an internal discussion, it became clear that this |
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
May 24, 2024
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
May 24, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no health info available from the health node, the status should be UNKNOWN instead of GREEN.