-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the Health API basic YAML tests #108811
Extend the Health API basic YAML tests #108811
Conversation
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the CI is happy, LGTM! Thanks for fixing this, so happy we are unmuting this test!
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/health/10_basic.yml
Show resolved
Hide resolved
Hm, this is different than I expected, why did you create a health folder for ilm and slm and did not add just another yaml file in the existing folder? |
Didn't put too much thought into it tbh, but I thought it made sense because those folders are testing different features. Is there any reason I shouldn't do that? |
I do not think they are different features. It's the health of ILM in one case and SLM in the other. I think it makes sense to keep them together. Don't you think? |
I don't have a strong opinion; I'm fine with either. I've moved them to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @nielsbauman !
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
* Extend the Health API basic YAML tests (#108811) The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators. * Fix YAML syntax * Merge and bump Health API YAML tests (#109009) * Remove data stream checks due to missing module
* Extend the Health API basic YAML tests (#108811) The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators. * Merge and bump Health API YAML tests (#109009)
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
Fixes #107796