Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ingest byte stats even when 0-valued #108796

Conversation

parkertimmins
Copy link
Contributor

@parkertimmins parkertimmins commented May 17, 2024

Change the ingest byte stats to always be returned whether or not they have a value of 0. Add human readable form of byte stats. Update docs to reflect changes.

Related to #107240

Change the ingest byte stats to always be returned
whether or not they have a value of 0. Add human readable
form of byte stats. Update docs to reflect changes.
Copy link

Documentation preview:

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Parker

@parkertimmins parkertimmins marked this pull request as ready for review May 20, 2024 14:53
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label May 20, 2024
@parkertimmins parkertimmins added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP and removed needs:triage Requires assignment of a team area label labels May 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @parkertimmins, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label May 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@parkertimmins parkertimmins merged commit 3662d12 into elastic:main May 20, 2024
15 checks passed
@parkertimmins parkertimmins deleted the ingest-byte-stats-response-fields-non-optional branch May 20, 2024 15:52
jedrazb pushed a commit to jedrazb/elasticsearch that referenced this pull request May 21, 2024
Change the ingest byte stats to always be returned
whether or not they have a value of 0. Add human readable
form of byte stats. Update docs to reflect changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants