Refactor RestClientTransport to allow using other http client libraries #584
+2,435
−464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the logic related to high-level API objects (serialization, deserialization, error handling, etc) that exists in
RestClientTransport
to a new abstractElasticsearchTransportBase
class. This class delegates http processing to implementations of a newTransportHttpClient
interface.The goal is to allow additional implementations to be provided, such as one based on the builtin http client in JDK11+, and allow users to easily implement their own when needed. The new
example-transports
sub-project contains an example implementation that uses Netty.Note that
ElasticsearchTransportBase
does not implement multi-node retry and cluster sniffing, which is provided byRestClient
and would have to be re-implemented for other http libraries.Fixes #550