Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up URL path encoding and remove dependency on httpclient #576

Merged
merged 1 commit into from
May 22, 2023
Merged

Speed up URL path encoding and remove dependency on httpclient #576

merged 1 commit into from
May 22, 2023
+94 −15

Conversation

swallez
Copy link
Member

@swallez swallez commented May 22, 2023

Rewrite EndpointBase.pathEncode:

  • remove dependency on Apache httpclient. Dependencies on that library are now limited to transport.rest_client since this transport is based on Apache httpclient.
  • speed up path encoding, as this function only needs to encode a path segment and not a list of segments like the one provided by Apache httpclient.

@swallez swallez merged commit d45687f into main May 22, 2023
@swallez swallez deleted the improve-path-encoding branch May 22, 2023 15:18
@github-actions github-actions bot mentioned this pull request May 22, 2023
Merged
github-actions bot pushed a commit that referenced this pull request May 22, 2023
@swallez @github-actions
Speed up URL path encoding and remove dependency on httpclient (#576)
411c075
github-actions bot pushed a commit that referenced this pull request May 22, 2023
@swallez @github-actions
Speed up URL path encoding and remove dependency on httpclient (#576)
abdcef1
@github-actions github-actions bot mentioned this pull request May 22, 2023
Merged
swallez added a commit that referenced this pull request May 22, 2023
@github-actions @swallez
Speed up URL path encoding and remove dependency on httpclient (#576) (…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e2e2e67 
…#577)

Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
swallez added a commit that referenced this pull request May 22, 2023
@github-actions @swallez
Speed up URL path encoding and remove dependency on httpclient (#576) (…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
96716b8 
…#578)

Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport 7.17 backport 8.8 Category: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@swallez