Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exe error checks #148

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

Closes #135

This fixes an issue where our permissions checks for fetching /proc/pid/exe could fail for kernel procs and certain docker configs.

Also re-enables one of the tests.

Why is it important?

This is a bug that causes data loss.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
eliottness Eliott Bouhana
@fearful-symmetry fearful-symmetry added the bug Something isn't working label Apr 25, 2024
@fearful-symmetry fearful-symmetry self-assigned this Apr 25, 2024
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner April 25, 2024 17:45
@fearful-symmetry fearful-symmetry requested review from faec and leehinman and removed request for a team April 25, 2024 17:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@fearful-symmetry fearful-symmetry merged commit cea4f3e into elastic:main May 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error checks when reading /proc/[pid]/exe don't account for kernel processes or docker permissions shenanigans
4 participants