Skip to content

Update some dependencies, change how go is installed in windows #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Apr 23, 2024

Update a bunch of dependencies
Use gvm through the powershell on windows to install go.

Verified

This commit was signed with the committer’s verified signature.
JamesNK James Newton-King
@michel-laterman michel-laterman added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team dependency labels Apr 23, 2024
@michel-laterman michel-laterman requested a review from a team as a code owner April 23, 2024 20:54
@michel-laterman michel-laterman requested review from fearful-symmetry and faec and removed request for a team April 23, 2024 20:54
@pierrehilbert
Copy link

We have some failures here:

C:\Users\buildkite\go\pkg\mod\go.opentelemetry.io\otel@v1.25.0\attribute\set.go:10:2: package slices is not in GOROOT (C:\Program Files\Go\src\slices)
note: imported by a module that requires go 1.21

@michel-laterman
Copy link
Contributor Author

I think there's an issue with how the windows tests are setup, the incorect version of go is being used:

Chocolatey installed 1/1 packages.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Refreshing environment variables from the registry for powershell.exe. Please wait...
Finished
go version go1.20.5 windows/amd64

Verified

This commit was signed with the committer’s verified signature.
JamesNK James Newton-King

Verified

This commit was signed with the committer’s verified signature.
JamesNK James Newton-King
@michel-laterman michel-laterman changed the title Update some dependencies Update some dependencies, change how go is installed in windows Apr 25, 2024
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michel-laterman michel-laterman merged commit 15b496a into main Apr 25, 2024
5 checks passed
@michel-laterman michel-laterman deleted the update-deps branch April 25, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants