Make cgroup errors skippable in system/process #134
Merged
+61
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
requested review from
ycombinator and
leehinman
and removed request for
a team
leehinman
approved these changes
Mar 20, 2024
leehinman
approved these changes
Apr 1, 2024
Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes it so cgroup-specific errors don't fail an entire PID, so the PID will still be reported even if we have cgroup errors.
Why is it important?
This is a sort of band-aid for #132, as I'm not sure how long a "proper" fix for that will take, as it might require significant changes to the cgroup client, as well as a considerable degree of testing.
Checklist
CHANGELOG.md