Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fips): update keystore to use crypto/pbkdf2 in go 1.24 #289

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Mar 6, 2025

What does this PR do?

the keystore is not used in fips mode but importing the pkg is causing x/crypto to be linked in the final binary. We can't drop go 1.23 so just add build tags to use stdlib crypto/pbkdf2 if the app is on go 1.24 (which is required for fips anyway).

Why is it important?

users of this library are importing x/crypto which is linked in the final binary due to this

x/crypto usage should be remove in fips mode

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

Related issues

Sorry, something went wrong.

the keystore is not used in fips mode but importing the pkg is
causing x/crypto to be linked in the final binary.
We can't drop go 1.23 so just add build tags to use stdlib
crypto/pbkdf2 if the app is on go 1.24 (which is required for
fips anyway).
@kruskall kruskall requested a review from a team as a code owner March 6, 2025 03:37
@kruskall kruskall requested review from faec and VihasMakwana and removed request for a team March 6, 2025 03:37
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@kruskall kruskall merged commit 12e5e9c into elastic:main Mar 7, 2025
5 checks passed
@kruskall kruskall deleted the feat/keystore-fips branch March 7, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants