feat(fips): update keystore to use crypto/pbkdf2 in go 1.24 #289
+67
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
the keystore is not used in fips mode but importing the pkg is causing x/crypto to be linked in the final binary. We can't drop go 1.23 so just add build tags to use stdlib crypto/pbkdf2 if the app is on go 1.24 (which is required for fips anyway).
Why is it important?
users of this library are importing x/crypto which is linked in the final binary due to this
x/crypto usage should be remove in fips mode
Checklist
Author's Checklist
Related issues