fix: do not leak testify package in tlscommon #271
Merged
+28
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move testify methods to a separate test package to avoid polluting the module graph for downstream clients and leaking the dependency
kruskall
requested review from
AndersonQ and
belimawr
and removed request for
a team
cmacknz
approved these changes
Jan 31, 2025
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
move testify methods to a separate test package to avoid polluting the module graph for downstream clients and leaking the dependency
Why is it important?
test dependencies shouldn't be used in non-test packages
Checklist
Author's Checklist
Related issues