Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easier extending custom collections #467

Merged
merged 11 commits into from May 6, 2023
Merged

easier extending custom collections #467

merged 11 commits into from May 6, 2023

Commits on Apr 29, 2023

  1. feat: move tag.createNode to static nodeClass.from 

    Re: eemeli#457
    @isaacs
    isaacs committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    06459bf View commit details
    Browse the repository at this point in the history

  2. chore(YAMLSeq): import from createNode, not utils 

    Prevents circular module reference
    @isaacs
    isaacs committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    b9a5f07 View commit details
    Browse the repository at this point in the history

  3. feat(collections): use tagObj.nodeClass if present

    @isaacs
    isaacs committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    ca08aa0 View commit details
    Browse the repository at this point in the history

  4. feat: instantiate collection nodes with nodeClass

    @isaacs
    isaacs committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    54c0d4d View commit details
    Browse the repository at this point in the history

  5. feat: custom map test, collection type match error

    @isaacs
    isaacs committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    7ba6f98 View commit details
    Browse the repository at this point in the history

  6. feat(docs): add collection examples to custom tag

    @isaacs
    isaacs committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    a87d40b View commit details
    Browse the repository at this point in the history

  7. fix: remove unused variable in types test

    @isaacs
    isaacs committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    63fbadb View commit details
    Browse the repository at this point in the history

  8. chore: code style 

    Updates from PR review
    @isaacs
    isaacs committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    b963fc7 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. fix: various code review fixes 

    - remove unnecessary check for undeterminable expType
- lookup tag by both tagName and collection type
- clearer NodeClass typecast
- specify schema param to NodeClass constructor
    @isaacs
    isaacs committed May 2, 2023
    Configuration menu
    Copy the full SHA
    524e132 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. chore: Satisfy ESLint & Prettier

    @eemeli
    eemeli committed May 6, 2023
    Configuration menu
    Copy the full SHA
    490842c View commit details
    Browse the repository at this point in the history

  2. Update src/nodes/YAMLSeq.ts

    @eemeli
    eemeli committed May 6, 2023
    Configuration menu
    Copy the full SHA
    3b9b194 View commit details
    Browse the repository at this point in the history