Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to StyleCop.Analyzers 1.2.0-beta.556 #869

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

edumserrano
Copy link
Owner

@edumserrano edumserrano commented Mar 3, 2024

Using StyleCop.Analyzers 1.2.0-beta.556 because I want to be able to enable SA1010.

With .NET 8 I had to temporarily disable it until the StyleCop.Analyzers updated their analyzers to be compatible with the language changes in .NET8. The issue was reported in DotNetAnalyzers/StyleCopAnalyzers#3687 and fixed in DotNetAnalyzers/StyleCopAnalyzers#3745 but a stable package hasn't been released yet so I'm using a pre-release version.

Also fixes: edumserrano/ideas#3

Copy link

github-actions bot commented Mar 3, 2024

Test runs on ubuntu-latest for commit 1e1f08c

✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:17:05 - 2024-03-03 10:17:12
Run Duration: 6s 484ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 6.0.27) [xUnit.net 00:00:00.39]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:01.11]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:01.11]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.75]   Finished:    DotNet.Sdk.Extensions.Testing.Tests 
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:17:13 - 2024-03-03 10:17:22
Run Duration: 9s 757ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 6.0.27) [xUnit.net 00:00:00.12]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.24]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.24]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.25]   Finished:    DotNet.Sdk.Extensions.Tests 
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:17:24 - 2024-03-03 10:17:30
Run Duration: 5s 946ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 7.0.16) [xUnit.net 00:00:00.37]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.95]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.95]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.79]   Finished:    DotNet.Sdk.Extensions.Testing.Tests 
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:17:31 - 2024-03-03 10:17:41
Run Duration: 10s 53ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 7.0.16) [xUnit.net 00:00:00.09]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.17]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.17]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.17]   Finished:    DotNet.Sdk.Extensions.Tests 
----

Copy link

github-actions bot commented Mar 3, 2024

Test runs on windows-latest for commit 1e1f08c

✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:18:21 - 2024-03-03 10:18:33
Run Duration: 12s 647ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 6.0.27) [xUnit.net 00:00:01.00]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.86]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.86]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:06.87]   Finished:    DotNet.Sdk.Extensions.Testing.Tests 
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:18:34 - 2024-03-03 10:18:44
Run Duration: 10s 125ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 6.0.27) [xUnit.net 00:00:00.17]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.27]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.27]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.57]   Finished:    DotNet.Sdk.Extensions.Tests 
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:18:47 - 2024-03-03 10:18:59
Run Duration: 11s 915ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 7.0.16) [xUnit.net 00:00:01.03]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.59]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.59]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:06.15]   Finished:    DotNet.Sdk.Extensions.Testing.Tests 
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:19:00 - 2024-03-03 10:19:10
Run Duration: 9s 957ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 7.0.16) [xUnit.net 00:00:00.16]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.23]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.23]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.44]   Finished:    DotNet.Sdk.Extensions.Tests 
----

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.51%. Comparing base (49686b3) to head (1e1f08c).

Files Patch % Lines
...ocking/HttpResponseMessageMockDescriptorBuilder.cs 0.00% 1 Missing ⚠️
...sions/Polly/Http/Fallback/FallbackPolicyFactory.cs 50.00% 1 Missing ⚠️
...Polly/Policies/CircuitBreakerCheckerAsyncPolicy.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          76       76           
  Lines        1294     1294           
  Branches      118      118           
=======================================
  Hits         1223     1223           
  Misses         44       44           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edumserrano edumserrano merged commit 85ffbaa into main Mar 3, 2024
8 of 9 checks passed
@edumserrano edumserrano deleted the StyleCop.Analyzers-1.2.0-beta.556 branch March 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant